From a6636a9b0dd3d39a641166b1c701d119ac9e0217 Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Fri, 15 Apr 2022 09:53:30 +0200 Subject: [PATCH] Add TODO for upstreamConn.register race --- user.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/user.go b/user.go index 2b3b45e..536934f 100644 --- a/user.go +++ b/user.go @@ -205,6 +205,8 @@ func (net *network) runConn(ctx context.Context) error { defer net.user.srv.Identd.Delete(uc.RemoteAddr().String(), uc.LocalAddr().String()) } + // TODO: this is racy, we're not running in the user goroutine yet + // uc.register accesses user/network DB records uc.register(ctx) if err := uc.runUntilRegistered(ctx); err != nil { return fmt.Errorf("failed to register: %w", err)