From 03c546e8bf4f8fb7613bd364e918269fe607a541 Mon Sep 17 00:00:00 2001
From: Simon Ser <contact@emersion.fr>
Date: Wed, 4 Mar 2020 16:00:19 +0100
Subject: [PATCH] Remove unused user.getChannel, move getUpstream to user

---
 downstream.go |  2 +-
 server.go     | 37 +++++--------------------------------
 2 files changed, 6 insertions(+), 33 deletions(-)

diff --git a/downstream.go b/downstream.go
index bddeaa2..1ddc7fe 100644
--- a/downstream.go
+++ b/downstream.go
@@ -321,7 +321,7 @@ func (dc *downstreamConn) register() error {
 	}
 
 	if network != "" {
-		dc.upstream = dc.srv.getUpstream(network)
+		dc.upstream = dc.user.getUpstream(network)
 		if dc.upstream == nil {
 			dc.logger.Printf("failed registration: unknown upstream %q", network)
 			dc.SendMessage(&irc.Message{
diff --git a/server.go b/server.go
index 4d09240..bfcb5b9 100644
--- a/server.go
+++ b/server.go
@@ -82,31 +82,13 @@ func (u *user) forEachDownstream(f func(dc *downstreamConn)) {
 	u.lock.Unlock()
 }
 
-func (u *user) getChannel(name string, upstream *Upstream) (*upstreamChannel, error) {
-	var channel *upstreamChannel
-	var err error
-	u.forEachUpstream(func(uc *upstreamConn) {
-		if err != nil {
-			return
+func (u *user) getUpstream(name string) *Upstream {
+	for i, upstream := range u.srv.Upstreams {
+		if upstream.Addr == name {
+			return &u.srv.Upstreams[i]
 		}
-		if upstream != nil && uc.upstream != upstream {
-			return
-		}
-		if ch, ok := uc.channels[name]; ok {
-			if channel != nil {
-				err = fmt.Errorf("ambiguous channel name %q", name)
-			} else {
-				channel = ch
-			}
-		}
-	})
-	if channel == nil {
-		return nil, ircError{&irc.Message{
-			Command: irc.ERR_NOSUCHCHANNEL,
-			Params:  []string{name, "No such channel"},
-		}}
 	}
-	return channel, nil
+	return nil
 }
 
 type Upstream struct {
@@ -199,15 +181,6 @@ func (s *Server) getUser(name string) *user {
 	return u
 }
 
-func (s *Server) getUpstream(name string) *Upstream {
-	for i, upstream := range s.Upstreams {
-		if upstream.Addr == name {
-			return &s.Upstreams[i]
-		}
-	}
-	return nil
-}
-
 func (s *Server) Serve(ln net.Listener) error {
 	for {
 		netConn, err := ln.Accept()