diff --git a/src/elements/clock.rs b/src/elements/clock.rs index 39e9542..e2d1c0a 100644 --- a/src/elements/clock.rs +++ b/src/elements/clock.rs @@ -1,8 +1,8 @@ -use nom::sequence::separated_pair; use nom::{ bytes::complete::tag, character::complete::{char, digit1, space0}, combinator::{peek, recognize}, + sequence::separated_pair, IResult, }; @@ -14,20 +14,25 @@ use crate::parsers::eol; /// there are two types of clock: *closed* clock and *running* clock. #[cfg_attr(test, derive(PartialEq))] #[cfg_attr(feature = "serde", derive(serde::Serialize))] +#[cfg_attr(feature = "serde", serde(untagged))] #[derive(Debug)] pub enum Clock<'a> { /// closed Clock Closed { start: Datetime<'a>, end: Datetime<'a>, + #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] repeater: Option<&'a str>, + #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] delay: Option<&'a str>, duration: &'a str, }, /// running Clock Running { start: Datetime<'a>, + #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] repeater: Option<&'a str>, + #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] delay: Option<&'a str>, }, } diff --git a/src/elements/drawer.rs b/src/elements/drawer.rs index a7228f7..01e52c2 100644 --- a/src/elements/drawer.rs +++ b/src/elements/drawer.rs @@ -1,4 +1,3 @@ -use crate::elements::Element; use crate::parsers::{eol, take_lines_till}; use nom::{ @@ -16,7 +15,7 @@ pub struct Drawer<'a> { impl Drawer<'_> { #[inline] - pub(crate) fn parse(input: &str) -> IResult<&str, (Element<'_>, &str)> { + pub(crate) fn parse(input: &str) -> IResult<&str, (Drawer<'_>, &str)> { let (input, name) = delimited( tag(":"), take_while1(|c: char| c.is_ascii_alphabetic() || c == '-' || c == '_'), @@ -25,7 +24,7 @@ impl Drawer<'_> { let (input, _) = eol(input)?; let (input, contents) = take_lines_till(|line| line.eq_ignore_ascii_case(":END:"))(input)?; - Ok((input, (Element::Drawer(Drawer { name }), contents))) + Ok((input, (Drawer { name }, contents))) } } @@ -33,12 +32,6 @@ impl Drawer<'_> { fn parse() { assert_eq!( Drawer::parse(":PROPERTIES:\n :CUSTOM_ID: id\n :END:"), - Ok(( - "", - ( - Element::Drawer(Drawer { name: "PROPERTIES" }), - " :CUSTOM_ID: id\n" - ) - )) + Ok(("", (Drawer { name: "PROPERTIES" }, " :CUSTOM_ID: id\n"))) ) } diff --git a/src/elements/inline_call.rs b/src/elements/inline_call.rs index 662e61a..afb8cf9 100644 --- a/src/elements/inline_call.rs +++ b/src/elements/inline_call.rs @@ -1,7 +1,7 @@ use nom::{ bytes::complete::{tag, take_till}, combinator::opt, - sequence::delimited, + sequence::{delimited, preceded}, IResult, }; @@ -19,19 +19,25 @@ pub struct InlineCall<'a> { pub end_header: Option<&'a str>, } -fn header(input: &str) -> IResult<&str, &str> { - delimited(tag("["), take_till(|c| c == ']' || c == '\n'), tag("]"))(input) -} - impl<'a> InlineCall<'a> { #[inline] pub(crate) fn parse(input: &str) -> IResult<&str, Element<'_>> { - let (input, _) = tag("call_")(input)?; - let (input, name) = take_till(|c| c == '[' || c == '\n' || c == '(' || c == ')')(input)?; - let (input, inside_header) = opt(header)(input)?; + let (input, name) = preceded( + tag("call_"), + take_till(|c| c == '[' || c == '\n' || c == '(' || c == ')'), + )(input)?; + let (input, inside_header) = opt(delimited( + tag("["), + take_till(|c| c == ']' || c == '\n'), + tag("]"), + ))(input)?; let (input, arguments) = delimited(tag("("), take_till(|c| c == ')' || c == '\n'), tag(")"))(input)?; - let (input, end_header) = opt(header)(input)?; + let (input, end_header) = opt(delimited( + tag("["), + take_till(|c| c == ']' || c == '\n'), + tag("]"), + ))(input)?; Ok(( input, diff --git a/src/elements/list.rs b/src/elements/list.rs index 326f501..83ba1dd 100644 --- a/src/elements/list.rs +++ b/src/elements/list.rs @@ -18,45 +18,46 @@ impl List { .unwrap_or((0, text)); let ordered = is_item(tail)?; - let bytes = text.as_bytes(); - let mut lines = memchr_iter(b'\n', bytes) - .map(|i| i + 1) - .chain(once(text.len())); - let mut pos = lines.next()?; - while let Some(i) = lines.next() { - let line = &text[pos..i]; - return if let Some(line_indent) = line.find(|c: char| !c.is_whitespace()) { - // this line is no empty + let mut last_end = 0; + let mut start = 0; + + for i in memchr_iter(b'\n', text.as_bytes()) + .map(|i| i + 1) + .chain(once(text.len())) + { + let line = &text[start..i]; + if let Some(line_indent) = line.find(|c: char| !c.is_whitespace()) { if line_indent < indent || (line_indent == indent && is_item(&line[line_indent..]).is_none()) { - Some((&text[pos..], List { indent, ordered }, &text[0..pos])) + return Some(( + &text[start..], + List { indent, ordered }, + &text[0..start - 1], + )); } else { - pos = i; + last_end = 0; + start = i; continue; } - } else if let Some(next_i) = lines.next() { - // this line is empty - let line = &text[i..next_i]; - if let Some(line_indent) = line.find(|c: char| !c.is_whitespace()) { - if line_indent < indent - || (line_indent == indent && is_item(&line[line_indent..]).is_none()) - { - Some((&text[pos..], List { indent, ordered }, &text[0..pos])) - } else { - pos = next_i; - continue; - } - } else { - Some((&text[next_i..], List { indent, ordered }, &text[0..pos])) - } } else { - Some((&text[i..], List { indent, ordered }, &text[0..pos])) - }; + // this line is empty + if last_end != 0 { + return Some((&text[i..], List { indent, ordered }, &text[0..last_end])); + } else { + last_end = start; + start = i; + continue; + } + } } - Some((&text[pos..], List { indent, ordered }, &text[0..pos])) + if last_end != 0 { + Some(("", List { indent, ordered }, &text[0..last_end])) + } else { + Some(("", List { indent, ordered }, text)) + } } } diff --git a/src/elements/mod.rs b/src/elements/mod.rs index 9fe1593..ad6d127 100644 --- a/src/elements/mod.rs +++ b/src/elements/mod.rs @@ -55,7 +55,7 @@ pub use self::{ #[derive(Debug)] #[cfg_attr(test, derive(PartialEq))] #[cfg_attr(feature = "serde", derive(serde::Serialize))] -#[cfg_attr(feature = "serde", serde(tag = "type", rename_all = "snake_case"))] +#[cfg_attr(feature = "serde", serde(tag = "type", rename_all = "kebab-case"))] pub enum Element<'a> { SpecialBlock(SpecialBlock<'a>), QuoteBlock(QuoteBlock<'a>), @@ -83,7 +83,6 @@ pub enum Element<'a> { List(List), ListItem(ListItem<'a>), Macros(Macros<'a>), - Planning(Planning<'a>), Snippet(Snippet<'a>), Text { value: &'a str }, Paragraph, @@ -162,7 +161,6 @@ impl_from!( Link, ListItem, Macros, - Planning, QuoteBlock, Snippet, SourceBlock, diff --git a/src/elements/snippet.rs b/src/elements/snippet.rs index b5ab4f0..cc55266 100644 --- a/src/elements/snippet.rs +++ b/src/elements/snippet.rs @@ -1,5 +1,5 @@ use nom::{ - bytes::complete::{tag, take, take_until, take_while1}, + bytes::complete::{tag, take_until, take_while1}, sequence::{delimited, separated_pair}, IResult, }; @@ -24,7 +24,7 @@ impl Snippet<'_> { tag(":"), take_until("@@"), ), - take(2usize), + tag("@@"), )(input)?; Ok((input, Element::Snippet(Snippet { name, value }))) @@ -40,7 +40,7 @@ fn parse() { Element::Snippet(Snippet { name: "html", value: "" - },) + }) )) ); assert_eq!( @@ -50,7 +50,7 @@ fn parse() { Element::Snippet(Snippet { name: "latex", value: "any arbitrary LaTeX code", - },) + }) )) ); assert_eq!( @@ -60,7 +60,7 @@ fn parse() { Element::Snippet(Snippet { name: "html", value: "", - },) + }) )) ); assert_eq!( @@ -70,7 +70,7 @@ fn parse() { Element::Snippet(Snippet { name: "html", value: "
@
", - },) + }) )) ); assert!(Snippet::parse("@@html:@").is_err()); diff --git a/src/elements/timestamp.rs b/src/elements/timestamp.rs index a45e138..a8e4d4f 100644 --- a/src/elements/timestamp.rs +++ b/src/elements/timestamp.rs @@ -22,7 +22,9 @@ pub struct Datetime<'a> { pub month: u8, pub day: u8, pub dayname: &'a str, + #[cfg_attr(feature = "serde", serde(skip_serializing_if = "Option::is_none"))] pub hour: Option